Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add one more test for invalid package insertion #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add one more test for invalid package insertion #142

wants to merge 1 commit into from

Conversation

tuxdna
Copy link
Contributor

@tuxdna tuxdna commented Mar 29, 2018

@tuxdna tuxdna mentioned this pull request Mar 29, 2018
Closed
3 tasks
@centos-ci
Copy link
Collaborator

@tuxdna Your image is available in the registry: docker pull registry.devshift.net/bayesian/data-model-importer:SNAPSHOT-PR-142

@tuxdna tuxdna requested a review from tisnik March 29, 2018 13:51
tisnik
tisnik reviewed Mar 29, 2018
View reviewed changes
test/test_insertion_from_minio.py
]

# if True: # with pytest.raises(RuntimeError):
try:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not to use pytest.raises referenced in the comment?

@geetikabatra
Copy link
Contributor

[test]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisnik tisnik tisnik left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuxdna @centos-ci @geetikabatra @tisnik