Fix bug with yearly.seasonality = 1
#2641
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm trying to create a lesson plan for my class teaching them intuition on how
prophet
works. One thing I want to do is setyearly.seasonality = 0
, then1
so they can see how the plot components vary (and see the Fourier terms). But, there's a small bug in the code that checksarg == TRUE
which returns TRUE whenarg == 1
. Switching toisTRUE()
fixes this