Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

adds absolute path to oembed GET as DEFAULT_ENDPOINT is not supported #163

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JONBRWN
Copy link

@JONBRWN JONBRWN commented May 7, 2015

fix for issue #162

@@ -21,7 +21,7 @@ module Embedding
def oembed(*args)
url = args.first
return nil unless url
get("oembed?url=#{url}", {}, false, false, true)
get("/https://api.instagram.com/oembed?url=#{url}", {}, false, false, true)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just change this to:

get("/oembed?url=#{url}", {}, false, false, true)

That's how we've monkey-patched it to fix it. That way, it still uses the configuration's endpoint, but throws away the /v1 path.

@JONBRWN
Copy link
Author

JONBRWN commented May 10, 2015

@fusion2004 thanks, wasn't sure that'd work. Def makes it a simpler solution

@jGRUBBS
Copy link

jGRUBBS commented Jul 6, 2015

When will this be pulled in? The issue and PR have been open for 2 months now.

@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@toshimaru
Copy link

+1

3 similar comments
@flaviomestre
Copy link

+1

@istateside
Copy link

+1

@asgerb
Copy link

asgerb commented Oct 18, 2015

+1

@chamini2
Copy link

+1.

@klacointe
Copy link
Contributor

+1

@jGRUBBS
Copy link

jGRUBBS commented Dec 15, 2015

Looks like this no longer works. The oembed endpoint has changed multiple times and does not seem to consistent with the rest of the API. For this to work with the current API the method would need to be changed to:

def oembed(*args)
  url = args.first
  return nil unless url
  get("https://api.instagram.com/oembed/?url=#{url}", {}, false, false, true)
end

@ghost ghost added the CLA Signed label Jul 12, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants