delete NGSecurityManager

[dwightguth]

This class relies on the deprecated functionality of System.setSecurityManager which was removed in Java 18. There is no way to fully restore the previous behavior, because Java does not provide any other way to cancel a call to System.exit, but you can still exit a nail by using the nailMain entry point and calling the exit function on the NGContext object it provides.

Without this change, the nailgun server will not start unless you are using the Java 17 JVM or older.

[facebook-github-bot]

Hi @dwightguth!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[fommil]

Confirmed, nailgun no longer works on Java 19 because of this.

I recommend deleting all references to originalSecurityManager as the more correct fix.

[dwightguth]

Ah, oops, I missed those lines. Will push up a fix shortly.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!