Allow building shared libraries when requested #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Not sure why CI is failing, but this was true on |
|
@genevievehelsel has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
I manually reran the action, maybe try to pull and rebase and submit again if the retried signal is still red? |
CMake builds static libraries by default unless requested otherwise with `BUILD_SHARED_LIBS`. However, this is made impossible when you pass `STATIC` to `add_library`. Passing `STATIC` isn't really necessary, and can be a hinderance for downstream users. See, for example, facebook/mvfst#302.
carlocab
force-pushed
the
enable-build-shared
branch
from
01bca70
to
9c113dc
Compare
|
Tried rebasing, but |
|
@genevievehelsel merged this pull request in e052d5f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake builds static libraries by default unless requested otherwise with
BUILD_SHARED_LIBS. However, this is made impossible when you passSTATICtoadd_library.Passing
STATICisn't really necessary, and can be a hinderance fordownstream users. See, for example, facebook/mvfst#302.