Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sync_wait a proper CPO. #369

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

egorich239
Copy link
Contributor

The sync_wait CPO by default defers to sync_wait_r</*deduced-type*/> which matches the preexisting behavior. Overriding sync_wait_r<T> hence by default is enough to consistently customize the behavior of both algorithms.

As an aside I matched piped API of sync_wait and sync_wait_r.

Also match piped API of sync_wait and sync_wait_r.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2021
@AnujYamdagni
Copy link
Contributor

We're doing repo cleanup - Can you add more information in your summary about the motivation behind this PR?

Copy link
Contributor

@AnujYamdagni AnujYamdagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for further discussion

@LeeHowes
Copy link
Contributor

The POR is that we don't want pipe syntax for sync_wait, so that aspect of this we shouldn't merge.

@facebook-github-bot
Copy link

Hi @egorich239!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants