Use nested namespce definition in "/vector" directory #11147
+42
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
lingbin
changed the title
lingbin
force-pushed
the
use-nested-namespace-in-vector-dir
branch
from
aa11028
to
e0039a5
Compare
Yuhta
approved these changes
Oct 2, 2024
Yuhta
added
the
ready-to-merge
lingbin
force-pushed
the
use-nested-namespace-in-vector-dir
branch
from
e0039a5
to
1f6a08e
Compare
The Velox code specification requires to always use "nested namespace definition", but I found that although most of the files in the "/vector" directory are already used, there are still some files that are not used. This patch fixes this problem. No functional changes.
lingbin
force-pushed
the
use-nested-namespace-in-vector-dir
branch
from
1f6a08e
to
8de2869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Velox code specification requires to always use "nested namespace
definition", but I found that although most of the files in the
"/vector" directory are already used, there are still some files that
are not used. This patch fixes this problem.
No functional changes.