Update dependencies #117
Closed
Update dependencies #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
shubho
approved these changes
Nov 14, 2023
|
@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jimouris
force-pushed
the
update-deps
branch
from
30c3843
to
d468211
Compare
|
@prasadbuddhavarapu merged this pull request in 932915c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Motivation and Context / Related issue
Update dependencies and remove some unused ones.
cc: @prasadbuddhavarapu @shubho The file
protocol/src/suid_create/mod.rsin line 163 is usingBASEPOINT_ORDERwhich curve25519_dalek after version 4 does not consider in the public API. Check here. I haven't changed that as it's part of the SUID protocol. It works fine but it throws a warning.Checklist