Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unstricted model loading #938

Merged
merged 4 commits into from
Dec 27, 2024
Merged

Allow unstricted model loading #938

merged 4 commits into from
Dec 27, 2024

Conversation

antoine-tran
Copy link
Contributor

We want to extend the ModelLoader API by allowing load checkpoints with incomplete parameters to a registered model. This is useful where different model blocks are delivered in different checkpoints (for example, to save spaces), as in the cases with the V-JEPA checkpoints (https://github.com/facebookresearch/jepa)

Fixes #{issue number}

Does your PR introduce any breaking changes? If yes, please list them:
List of all backwards-incompatible changes.

Check list:

  • Was the content of this PR discussed and approved via a GitHub issue? (no need for typos or documentation improvements)
  • Did you read the contributor guideline?
  • Did you make sure that your PR does only one thing instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (no need for typos, documentation, or minor internal changes)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 26, 2024
Tuan Tran added 2 commits December 26, 2024 17:14
antoine-tran pushed a commit that referenced this pull request Dec 26, 2024
Copy link
Contributor

@cbalioglu cbalioglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbalioglu cbalioglu merged commit 728c951 into main Dec 27, 2024
15 checks passed
@cbalioglu cbalioglu deleted the tuan/partial_model_load branch December 27, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants