Update __init__.py #4086
Closed
Update __init__.py #4086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix erroneous logging `Failed to load GPU Faiss: No module named 'swigfaiss_gpu'. Will not load constructor refs for GPU indexes.` when I was running on a GPU-based index just fine
|
@asadoughi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
asadoughi
added a commit
to asadoughi/torchrec
that referenced
this pull request
Dec 12, 2024
Summary: Fix erroneous logging `Failed to load GPU Faiss: No module named 'swigfaiss_gpu'. Will not load constructor refs for GPU indexes.` when I was running on a GPU-based index just fine. `GpuIndex...` is loaded via loader.py. X-link: facebookresearch/faiss#4086 Reviewed By: mnorris11 Differential Revision: D67118292 Pulled By: asadoughi
|
@asadoughi merged this pull request in 5f0a99a. |
facebook-github-bot
pushed a commit
to pytorch/torchrec
that referenced
this pull request
Dec 12, 2024
Summary: Pull Request resolved: #2628 Fix erroneous logging `Failed to load GPU Faiss: No module named 'swigfaiss_gpu'. Will not load constructor refs for GPU indexes.` when I was running on a GPU-based index just fine. `GpuIndex...` is loaded via loader.py. X-link: facebookresearch/faiss#4086 Test Plan: before ``` (faiss_gpu_cuvs_nightly) [[email protected] ~]$ python3 script.py Failed to load GPU Faiss: No module named 'swigfaiss_gpu'. Will not load constructor refs for GPU indexes. ``` after ``` (faiss_gpu_cuvs_nightly) [[email protected] ~]$ python3 Python 3.12.8 | packaged by conda-forge | (main, Dec 5 2024, 14:24:40) [GCC 13.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import faiss >>> ``` Reviewed By: mnorris11 Differential Revision: D67118292 Pulled By: asadoughi fbshipit-source-id: aa05aa20fe61e4ad75d4234f52e3b0d6a673a0b9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix erroneous logging
Failed to load GPU Faiss: No module named 'swigfaiss_gpu'. Will not load constructor refs for GPU indexes.when I was running on a GPU-based index just fine.GpuIndex...is loaded via loader.py.