Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Nevergrad's CI parallel #1385

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Making Nevergrad's CI parallel #1385

wants to merge 7 commits into from

Conversation

teytaud
Copy link
Contributor

@teytaud teytaud commented Mar 14, 2022

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 14, 2022
@teytaud
Copy link
Contributor Author

teytaud commented Mar 14, 2022

The idea here is that it is both faster and more economical / ecological, because bugs are found after less tests when the order is not sequential. This is because most errors typically breaks all tests in one of the block of tests, so a randomized (or parallel) order will be more likely to find early. It would be great to have a clever order though (I'm trying to do that, ideally I'd like to do one test per test file first).

@teytaud
Copy link
Contributor Author

teytaud commented Mar 14, 2022

Hum I see that we can go up to 300. Should we use 10 ?

@teytaud teytaud requested a review from jrapin March 14, 2022 14:49
@jrapin
Copy link
Contributor

jrapin commented Mar 14, 2022

does it actually go faster?
22min is the standard time I think, so this does not change anything right now

@teytaud
Copy link
Contributor Author

teytaud commented Mar 14, 2022

I guess it's much more complicated than that... we need to split, otherwise CircleCI just runs all tests on all machines, which is not what we want to do :-)

@teytaud
Copy link
Contributor Author

teytaud commented Mar 14, 2022

(it's cool for testing flakiness though...)
i'll see what I can do for this.

@jrapin
Copy link
Contributor

jrapin commented Mar 15, 2022

(it's cool for testing flakiness though...) i'll see what I can do for this.

In term of environment it's a disaster though, i'd rather avoid it

@jrapin
Copy link
Contributor

jrapin commented Mar 24, 2022

the best option for shortening the CI is to shorten (not remove) the slowest tests. I'm pretty sure we can go below 10min this way in a day or so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants