Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smac & smac2 #1388

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

smac & smac2 #1388

wants to merge 4 commits into from

Conversation

teytaud
Copy link
Contributor

@teytaud teytaud commented Mar 15, 2022

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@teytaud teytaud marked this pull request as draft March 15, 2022 14:23
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 15, 2022
jrapin
jrapin reviewed Mar 15, 2022
View reviewed changes
nevergrad/optimization/recastlib.py
thread = threading.Thread(target=dummy_function)
thread.start()

def smac_obj(p):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please deduplicate as much as possible here, this is hell to maintain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrapin jrapin jrapin left review comments

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teytaud @jrapin @facebook-github-bot