Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cmn ASR eval in SeamlessExpressive #352

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hygong-fb
Copy link

SeamlessExpressive evaluation of eng-cmn normalizes both transcribed and ground truth texts into simplified Chinese texts. It is observed that there is a mix of traditional and simplified Chinese characters in texts, which resulted in low ASR-BLEU. Therefore, chinese_converter is added to ASR-BLEU in SeamlessExpressive eval pipeline.

Test command:

python3 ${SEAMLESS_COMMUNICATION_ROOT}/src/seamless_communication/cli/expressivity/evaluate/run_asr_bleu.py
--generation_dir_path=${GENERATED_DIR}/${SPLIT}${SRC_LANG}${TGT_LANG}
--generate_tsv_filename=${GENERATED_TSV}
--tgt_lang=${TGT_LANG}

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 6, 2024
Copy link
Contributor

@uralik uralik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, although this might also be a problem in the main m4t v2 eval

@sravyapopuri388 tagging you here for awareness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants