Add preregister, earlyAccessEnabled, androidMaxVersion, originalPrice and discountEndDate properties #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed search: more section title is not always empty, it can contain "Apps" - fixed missing comments (ds:9 => ds:8) - new url called to test throttle, - updated expected results
…will answer quickly
jbigman
changed the title
|
code looks good to me, but there seems to be a test failure (not related to throttling). I suppose it's not related to the changes in here either, but do you know why it fails? |
|
Doing a netflix search does not return the exact same result between requests. I fixed both tests in the throttle fix PR #649 |
|
ok I'll wait for the tests ones to be finished and merged and then I'll get back to merging this one |
… interval and added comments on sinon usage.
… interval and added comments on sinon usage.
|
Please pull from main so we get tests passing here as well |
facundoolano
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sales properties
Was able to test it throug this list of games
PS : the original price is not always set, according to the language/country, the price could be discounted, but there is not data about the original price and the discount duration.
Pre registration properties
Was able to test it throug this list of games
Assertion on types are added in the generic method but there is no specific tests because no game will forever return preregistration or sales.
Android version upper limit