Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safer screenshots mapping #669

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Safer screenshots mapping #669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ const MAPPINGS = {
screenshots: {
path: ['ds:5', 1, 2, 78, 0],
fun: (screenshots) => {
if (screenshots === null) return [];
if (!screenshots?.length) return [];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this different from?

Suggested change
if (!screenshots?.length) return [];
if (!screenshots) return [];

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's different. If you remove ?.length, then this if goes falsy and code on the line 140 will be executed, but when screenshots is empty, then map returns an empty array.
So, if you leave part ?.length, then this check can be a little quicker.

return screenshots.map(R.path([3, 2]));
}
},
Expand Down
Loading