Issue #2625986: enforce type string for plugin IDs. #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -50,6 +50,9 @@ public function createReactionRule(array $configuration = []) { | |||
| * {@inheritdoc} | |||
| */ | |||
| public function createAction($id) { | |||
| if (!is_string($id)) { | |||
| throw new \InvalidArgumentException(t('Rules Action IDs must be strings.')); | |||
There was a problem hiding this comment.
Exception messages should not use t(), we are in the lowest levels of API here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drupal Issue https://www.drupal.org/node/2625986.
I'm starting out with bottleneck routines that get called a lot. No tests yet, but I want to get this out there so people can figure out where we need to better enforce types.
No test yet.