Change reaction-rule config to save the event with settings #405
Conversation
| event: | ||
| type: string | ||
| label: 'Event' | ||
| events: |
There was a problem hiding this comment.
unrelated, this seems wrong / outdated. Probably we can remove rules_expression.rules_reaction_rule - the plugin does not exist any more afair.
| * The events array. The array is numerically indexed and contains arrays | ||
| * with the following structure: | ||
| * - event_name: string with the event machine name. | ||
| * - configuration: an array containing the event configuration. |
There was a problem hiding this comment.
Description sentences should start upper-case
| */ | ||
| protected $event; | ||
| protected $events; |
There was a problem hiding this comment.
We should initialize this as empty array with "[]".
Conflicts: src/Engine/RulesComponent.php src/Form/ReactionRuleEditForm.php
| * Events array. The array is numerically indexed and contains arrays with the | ||
| * following structure: | ||
| * - event_name: String with the event machine name. | ||
| * - configuration: An array containing the event configuration. |
There was a problem hiding this comment.
This is a code smell if we need to document array keys. I think we should use a simple class instead which has this properties + methods documented. We should prevent nested array weirdness when we can.
There was a problem hiding this comment.
Agreed, but can we do that with CMI? I've only seen it save/load arrays.
As alternative, we could use an order array with
$event_name => $configuration
which Alex tried initially. Problem there was that we need to have dots in event names (as symfony events use dots), but CMI does not allow dots in config keys. Thus, we'd have to massage the event names and somehow escape/replace dots. That makes it more complicated, also when querying for events etc.
There was a problem hiding this comment.
we can file a follow-up to explore using objects instead of event arrays.
Conflicts: src/Entity/ReactionRuleStorage.php src/Form/ReactionRuleEditForm.php tests/src/Kernel/EventIntegrationTest.php
Conflicts: config/schema/rules.schema.yml
https://www.drupal.org/node/2666200