Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Bootstrap, AdminLTE & FontAwesome #552

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bump Bootstrap, AdminLTE & FontAwesome #552

wants to merge 3 commits into from

Conversation

samiashi
Copy link
Contributor

@samiashi samiashi commented Mar 29, 2024 •
edited
Loading

  • Bump Bootstrap to v5
  • Bump AdminLTE to v3.2.0
  • Bump FontAwesome to v6.5.1

Fixes #547

@farridav
Copy link
Owner

Nice, this is on my radar, though it will need checking through visually to make sure it all behaves nicely and still looks jazzy

PacificGilly
PacificGilly reviewed Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@PacificGilly PacificGilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR. Do you mind QAing this too, please?

README.md Outdated Show resolved Hide resolved
@jameslao
Copy link
Contributor

AdminLTE 3.2 is indeed a drop-in replacement but it's not targeting bootstrap 5 in itself... I remember having some issues with tabs when I upgraded bootstrap. That's why I tried to work with AdminLTE 4 even though it's in alpha. I'll submit a separate PR.

Sami El Achi and others added 2 commits March 30, 2024 21:30
Bump Bootstrap to version 5
34d2ddf 
Bump Admin LTE & FontAwesome
@samiashi @PacificGilly
Update README.md to add AdminLTE subversion
7368e6f 
Co-authored-by: James Gilmore <[email protected]>
@abe-101
Copy link

abe-101 commented Jun 19, 2024

Any update on this?

@SourceDoctor
Copy link
Contributor

would appreciate this change

@samiashi
Copy link
Contributor Author

@farridav @jameslao @PacificGilly any updates on this? Would be good to move this forward

@PacificGilly
Copy link
Collaborator

@farridav @jameslao @PacificGilly any updates on this? Would be good to move this forward

@samiashi Would you mind QAing this please with the test app? 🙂

@jucajuca
Copy link

jucajuca commented Aug 9, 2024

I could be wrong, but I think this merge request still needs to update the bootswatch themes.
https://bootswatch.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PacificGilly PacificGilly PacificGilly left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AdminLTE 4 and Bootstrap 5
7 participants
@samiashi @farridav @jameslao @abe-101 @SourceDoctor @PacificGilly @jucajuca