Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/updates for v5 #246

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Feat/updates for v5 #246

merged 5 commits into from
Mar 28, 2024

Conversation

nrayburn-tech
Copy link
Contributor

@nrayburn-tech nrayburn-tech commented Nov 2, 2023 •
edited
Loading

Fixes #245.

Checklist

@nrayburn-tech nrayburn-tech changed the base branch from master to next November 2, 2023 22:29
@nrayburn-tech
Copy link
Contributor Author

nrayburn-tech commented Nov 2, 2023 •
edited
Loading

  • Update workflow to use v4 tag.

@jsumners
Copy link
Member

jsumners commented Nov 3, 2023

The next branch on this repo is several months old and was last updated by @Uzlopak. We really need to be coordinating with the "I'm interested in working on this" issue prior to starting pull requests so that we know we have a valid branch to target. As it is, I have created https://github.com/fastify/avvio/tree/next-fastify-v5 for now and rebased this PR. Some coordination needs to happed to determine if this is appropriate or if changes in the current next branch need to be incorporated.

Also, a word of warning: this is a complicated module. We are likely going to want @mcollina's input on this one.

@jsumners jsumners changed the base branch from next to next-fastify-v5 November 3, 2023 13:07
@nrayburn-tech nrayburn-tech marked this pull request as ready for review March 19, 2024 00:04
@nrayburn-tech
Copy link
Contributor Author

This PR now contains the updates I'm aware of being needed from fastify/fastify#5116. If something additional needs to happen (as either this PR or a separate one) we can discuss it either here or in #245.

@gurgunday
Copy link
Member

gurgunday commented Mar 26, 2024 •
edited
Loading

I think we can combine them in next

If I understand correctly, @Uzlopak just removed express; there is no big change underway

Edit: asked Uzlopak directly

@gurgunday gurgunday changed the base branch from next-fastify-v5 to next March 28, 2024 13:09
@gurgunday gurgunday requested a review from mcollina March 28, 2024 13:09
mcollina
mcollina approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday merged commit 9801fc3 into fastify:next Mar 28, 2024
14 checks passed
jsumners added a commit that referenced this pull request Jul 13, 2024
@jsumners @Uzlopak
@gurgunday @nrayburn-tech
Merge next into master (#259)
b5408d8 
* chore: remove express (#227)

* Feat/updates for v5 (#246)

* Sync gitignore with fastify/skeleton

* Update workflows for fastify v5

* Update all dependencies

* merge

---------

Signed-off-by: Gürgün Dayıoğlu <[email protected]>
Co-authored-by: Gürgün Dayıoğlu <[email protected]>

* update fastify deps

---------

Signed-off-by: Gürgün Dayıoğlu <[email protected]>
Co-authored-by: Uzlopak <[email protected]>
Co-authored-by: Gürgün Dayıoğlu <[email protected]>
Co-authored-by: Nicholas Rayburn <[email protected]>
@Fdawgs Fdawgs mentioned this pull request Dec 28, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurgunday gurgunday gurgunday approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
v5 Work
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nrayburn-tech @jsumners @gurgunday @mcollina