Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return type of rateLimit #375

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix: return type of rateLimit #375

merged 1 commit into from
Sep 2, 2024

Conversation

MunifTanjim
Copy link
Contributor

@MunifTanjim MunifTanjim commented Jul 31, 2024 •
edited
Loading

Checklist

@MunifTanjim MunifTanjim marked this pull request as ready for review July 31, 2024 12:31
@MunifTanjim MunifTanjim mentioned this pull request Jul 31, 2024
Merged
4 tasks
@MunifTanjim
Copy link
Contributor Author

@jsumners @Uzlopak Can I get a review on this one? Without these changes we get TypeScript error when trying to use this package.

@jsumners
Copy link
Member

jsumners commented Aug 4, 2024

I cannot read TypeScript. Please do not tag me on any TypeScript changes.

mcollina
mcollina approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit f7b4f7e into fastify:master Sep 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MunifTanjim @jsumners @mcollina