-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AOT compilation: update to weval 0.2.12. #939
Conversation
aeea425
to
88e7480
Compare
@guybedford @elliottt I've intentionally avoided a submodule update here as we have the open issue with the new headers implementation in StarlingMonkey interacting with weval somehow in debug builds; the version of weval pulled in by the |
Hmm, this is triggering some issues deep in the Wasm backend; I need to investigate further. |
This includes a fix for irreducible control flow; see [this PR](cfallin/waffle#13) in waffle.
13075de
to
cdf5642
Compare
For what it is worth, the new headers work landed already in js-compute-runtime without any error, so we are already on the latest StarlingMonkey here. But fine to maintain separate versioning as well! |
I've pushed a new version of weval (0.2.12) with some additional fixes that I believe should pass tests now (let's see how CI does); analogous update in StarlingMonkey at bytecodealliance/StarlingMonkey#141.
Ah, interesting, and we're passing WPT here still -- I had been worried about hitting the same issue as bytecodealliance/StarlingMonkey#114 but I guess for whatever reason we don't see that here? In any case, I'm happy to do a separate PR to update to latest StarlingMonkey once above PR lands too, or land it first and update this one, either way. |
This includes a fix for irreducible control flow; see this PR in waffle.