Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migration changes #1832

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

migration changes #1832

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c581b09
migration changes
Heulitig Apr 5, 2024
95ef33d
minor fixes
Heulitig Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fastn-core/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ pub(crate) use tracker::Track;
pub(crate) use translation::{TranslatedDocument, TranslationData};
pub use {doc::resolve_foreign_variable2, doc::resolve_import};

pub const FASTN_UI_INTERFACE: &str = "fastn-stack.github.io/fastn-ui";
pub const FASTN_UI_INTERFACE: &str = "fastn-ui.fifthtry-site";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it not .site? Also can we remove fastn ui interface altogether, we are not using it, when we start using it we can revive this.

pub const PACKAGE_THEME_INTERFACE: &str = "ftd-lang.github.io/theme";
pub const NUMBER_OF_CRS_TO_RESERVE: usize = 5;

Expand Down
5 changes: 5 additions & 0 deletions ftd/src/interpreter/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,11 @@ pub fn get_argument_for_reference_and_remaining(
)>,
> {
if let Some((component_name, arguments)) = component_definition_name_with_arguments {
// Since we allow '.' in package names now which was not previously allowed
// To handle cases: (When package/site name starts with the component name)
// name: app-switcher.fifthtry-site#app-switcher.is-open
let name = name.trim_start_matches(format!("{}#", doc.name).as_str());

if let Some(referenced_argument) = name
.strip_prefix(format!("{}.", component_name).as_str())
.or_else(|| name.strip_prefix(format!("{}#{}.", doc.name, component_name).as_str()))
Expand Down
Loading