Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codeclimate fails using Credo 1.0 #14

Open
Eptis opened this issue Jan 7, 2019 · 7 comments
Open

Codeclimate fails using Credo 1.0 #14

Eptis opened this issue Jan 7, 2019 · 7 comments

Comments

@Eptis
Copy link

Eptis commented Jan 7, 2019

If I run codeclimate with the latest credo (v1.0) I get the error:

error: (CC::CLI::Analyze::EngineFailure) engine credo failed with status 1 and stderr
** (UndefinedFunctionError) function Credo.Check.Readability.AliasOrder.base_priority/0 is undefined (module Credo.Check.Readability.AliasOrder is not available)

Any idea how I can make a PR to update the codeclimate-credo plugin to include the latest Credo checks?

@fazibear
Copy link
Owner

I'll take a look at this. This version is not the final. There are PR waiting for merge on the credo side.

Anyway is standalone credo works fine for your project?

@Eptis
Copy link
Author

Eptis commented Jan 10, 2019

Yup standalone credo works fine. Its not so much the version that is incompatible, but the specific modules in those versions that are not present in codeclimate. Commenting those out works :) Let me know if I can contribute anything!

@fazibear
Copy link
Owner

Because credo guy doesn't respond to any of my PRs, I've forked it here
https://github.com/fazibear/credo/tree/codeclimate and patch it.
During the build, it fetches code from there. It may be out of date.

@maxjacobson
Copy link

@fazibear Hi there. I work at Code Climate. Anything I can do to help get this next release out?

@davehenton
Copy link

Hey @fazibear, Dave here with Code Climate -- just checking in here. Let me know if there's anything I can do to help with this next release. Thanks!

@davehenton
Copy link

hey @fazibear - just checking in here. Let me know how I can help out. Thanks!

@larkinscott
Copy link

Hey @fazibear - I work at Code Climate. I went ahead and forked this repo over to our community org and marked you as a collaborator. Hope that's ok! If so, can we archive this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants