Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hotkey method to Action #1070

Merged
merged 3 commits into from
Jun 6, 2024
Merged

add hotkey method to Action #1070

merged 3 commits into from
Jun 6, 2024

Conversation

eagleoflqj
Copy link
Member

It will be nice to show hotkey bound to actions in macOS menu like built-in Pinyin does.

src/lib/fcitx/action.h Show resolved Hide resolved
@eagleoflqj eagleoflqj requested a review from wengxt June 6, 2024 00:18
* @return key list.
* @since 5.1.11
*/
KeyList hotkey() const;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be const reference

*
* @since 5.1.11
*/
void setHotkey(const KeyList &);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should have parameter name

@eagleoflqj eagleoflqj requested a review from wengxt June 6, 2024 03:09
@wengxt wengxt merged commit 63b2ba5 into fcitx:master Jun 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants