UnsafeSendSync/ThreadPinned<T>: Data race allowed on T #557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found a memory-safety/soundness issue in this crate while scanning Rust code for potential vulnerabilities. This PR contains a fix for the issue.
Issue Description
ThreadPinned<T>
unconditionally implements Sync. This allows users to create data races onT: !Sync
. Such data races can lead to undefined behavior.feather/feather/plugin-host/src/thread_pinned.rs
Lines 44 to 45 in 2f99d76
same
feather/feather/old/server/types/src/task.rs
Lines 30 to 31 in 2f99d76