Implement RSA encryption (with update for current rewrite structure) #56
+74
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asurar0
reviewed
Sep 18, 2024
src/lib/net/encryption/src/key.rs
Outdated
Comment on lines
6
to
8
| pub public_key: RsaPublicKey, //public key side of the keypair (for encryption) | ||
| pub encoded_public_key: der::Document, //the public key encoded in ASN.1 DER format for publishing to the client | ||
| pub private_key: RsaPrivateKey, //private key side of the keypair (for decryption) |
There was a problem hiding this comment.
When documenting field the actual syntax should be:
/// public key side of the keypair (for encryption)
pub public_key: RsaPublicKeyAs it ties the documentation comment to the field that is then viewable with Rust-analyzer/LSP
Asurar0
suggested changes
Sep 18, 2024
src/lib/net/encryption/Cargo.toml
Outdated
Comment on lines
8
to
10
| rsa = "0.9.6" | ||
| der = "0.7.9" | ||
| rand = "0.8.5" |
There was a problem hiding this comment.
These dependencies should be placed in the workspace (project root) Cargo.toml and then imported as
crate = { workspace = true }
See https://github.com/ferrumc-rs/ferrumc/blob/rewrite/v3/src/lib/README.MD
|
fixed it |
|
facing version conflicts between rand and rand_core now |
|
@en1gma713 we've added the networking stack now, if you'd be able to sort out the conflicts and make sure all of your stuff works ok with the new code, im happy to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same as my last PR but it works this time and is up-to-date on the file structure