Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to use end date now #356

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shoerantner
Copy link

@shoerantner shoerantner commented Dec 23, 2020

I want to have the possibility to set the endDate to now

@fetrarij
Copy link
Owner

Hello @shoerantner ,

I really apreciate your improvment, but I think having it more cleaning and more customisable would be great.
I am thinking about something like defineEndDate or 'fixEndDateorendDateTo` or ... just to say the endDate is set fixed to a date provided.
example:

fixEndDateTo="2021-12-12"
[fixEndDateTo]="date" where date = now() in TS
....

What do you think about that?
Could you create a new PR for that?

Thank you, and sorry for the late reply :)

@lluisnieto
Copy link

This comment has nothing to do with this PR. Just to let the author know that this library, right now is broken. It does not compile in production mode. Dayjs cannot be loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants