Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin refactorings #11

Merged
merged 9 commits into from
Oct 22, 2024
Merged

Begin refactorings #11

merged 9 commits into from
Oct 22, 2024

Conversation

avahoffman
Copy link
Contributor

@avahoffman avahoffman commented Aug 23, 2024

This fails as is right now, but I'd recommend something like this to cut down on repetitive code. Anything that has happened in either anvilPoll2024MainAnalysis.Rmd or anvilPoll2024ExtraAnalysis.Rmd should be borrowed with knit_child.

Copy link
Contributor

github-actions bot commented Aug 23, 2024

No broken url errors! 🎉
Comment updated at 2024-10-22-05:08:20 with changes from dc79fd6

Copy link
Contributor

github-actions bot commented Aug 23, 2024

No spelling errors! 🎉
Comment updated at 2024-10-22-05:08:18 with changes from dc79fd6

Copy link
Contributor

github-actions bot commented Oct 16, 2024

👀 Quick preview of website here *
🔬 Comprehensive download of the website here

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-10-22 with changes from the latest commit dc79fd6

@kweav
Copy link
Contributor

kweav commented Oct 16, 2024

Gotta adjust the shared stylizing functions or main Rmd or pages Rmd's so that the + ggplot additions in Main carry over. Will do that next, but this is not quite ready yet.

@kweav
Copy link
Contributor

kweav commented Oct 17, 2024

@avahoffman this preview now successfully renders and I think it follows the original goal of the PR (though there were additional changes to the shared functions to make the style work better)

@avahoffman
Copy link
Contributor Author

YAY! So much cleaner! I think this one like #9 needs some formatting but I think we can address that later.

@kweav kweav merged commit 8fc957b into main Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants