Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more takeaways and separate by topic #4

Merged
merged 9 commits into from
Jun 5, 2024
Merged

add more takeaways and separate by topic #4

merged 9 commits into from
Jun 5, 2024

Conversation

kweav
Copy link
Contributor

@kweav kweav commented Jun 4, 2024

Updated pages/index.Rmd to include more takeaways and specifically separate them out by topic (linking the relevant page).

@kweav kweav requested a review from avahoffman June 4, 2024 19:08
Copy link
Contributor

github-actions bot commented Jun 4, 2024

No broken url errors! 🎉
Comment updated at 2024-06-05-17:25:53 with changes from 9a3f72c

Copy link
Contributor

github-actions bot commented Jun 4, 2024

No spelling errors! 🎉
Comment updated at 2024-06-05-17:25:51 with changes from 9a3f72c

Copy link
Contributor

github-actions bot commented Jun 4, 2024

👀 Quick preview of website here *
🔬 Comprehensive download of the website here

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-06-05 with changes from the latest commit 9a3f72c

@kweav
Copy link
Contributor Author

kweav commented Jun 4, 2024

I'm not sure if I'm a fan of separating them out by topic. The original looks more polished.

@kweav
Copy link
Contributor Author

kweav commented Jun 4, 2024

Do we need the flowchart image to be higher resolution?

@avahoffman
Copy link
Contributor

I think it looks pretty good! My concern is a really long bulleted list otherwise.

Yes, we'll want the flowchart in high res -- this could just be looking strange on the preview though.

@kweav
Copy link
Contributor Author

kweav commented Jun 4, 2024

I rebuilt the flowchart directly into that slidedeck -- it's a little different spacing wise now (seems bigger/more cramped), but does seem to be higher res on the website. What do you think? I prefer the old one, but want it to be a good resolution, so...

I first to use an svg in the slidedeck, but google slides doesn't seem to support

@avahoffman
Copy link
Contributor

Thanks for doing all that! We might need to use a static file. It still looks a bit pixely unfortunately

@kweav
Copy link
Contributor Author

kweav commented Jun 4, 2024

I think the static png looks all right!

Copy link
Contributor

@avahoffman avahoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor tweaks and I think it's ready!

pages/index.Rmd Outdated


```{r, eval=FALSE, fig.align='center', fig.alt= "Example image", echo = FALSE, out.width="100%"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep this chunk?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we don't need to if you like the static image!

pages/index.Rmd Outdated Show resolved Hide resolved
pages/index.Rmd Outdated Show resolved Hide resolved
@kweav
Copy link
Contributor Author

kweav commented Jun 5, 2024

@avahoffman did a read through to sync verb tenses more. How's it look? I'll go through takeaways on individual pages too and put that in another branch/PR if changes are needed

@kweav kweav mentioned this pull request Jun 5, 2024
Copy link
Contributor

@avahoffman avahoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kweav kweav merged commit 0901484 into main Jun 5, 2024
6 checks passed
@kweav kweav deleted the updateHomePage branch June 5, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants