-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more takeaways and separate by topic #4
Conversation
No broken url errors! 🎉 |
No spelling errors! 🎉 |
👀 Quick preview of website here * * note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea. Updated at 2024-06-05 with changes from the latest commit 9a3f72c |
I'm not sure if I'm a fan of separating them out by topic. The original looks more polished. |
Do we need the flowchart image to be higher resolution? |
I think it looks pretty good! My concern is a really long bulleted list otherwise. Yes, we'll want the flowchart in high res -- this could just be looking strange on the preview though. |
I rebuilt the flowchart directly into that slidedeck -- it's a little different spacing wise now (seems bigger/more cramped), but does seem to be higher res on the website. What do you think? I prefer the old one, but want it to be a good resolution, so... I first to use an svg in the slidedeck, but google slides doesn't seem to support |
Thanks for doing all that! We might need to use a static file. It still looks a bit pixely unfortunately |
I think the static png looks all right! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweaks and I think it's ready!
pages/index.Rmd
Outdated
|
||
|
||
```{r, eval=FALSE, fig.align='center', fig.alt= "Example image", echo = FALSE, out.width="100%"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to keep this chunk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we don't need to if you like the static image!
Co-authored-by: AM Hoffman <[email protected]>
Co-authored-by: AM Hoffman <[email protected]>
@avahoffman did a read through to sync verb tenses more. How's it look? I'll go through takeaways on individual pages too and put that in another branch/PR if changes are needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Updated
pages/index.Rmd
to include more takeaways and specifically separate them out by topic (linking the relevant page).