Ki map #11
Merged
Ki map #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No broken urls! 🎉 |
|
Re-rendered previews from the latest commit:
Updated at 2024-02-01 with changes from fdb0436 |
avahoffman
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
LGTM! I'm guessing the <sup> will be superseded by OTTR refs in #13
Can you make sure this is up to date with main?
The widget is not showing up - does it work locally? when you run bookdown::render_book('index.Rmd')
ehumph
approved these changes
Feb 1, 2024
|
No spelling errors! 🎉 |
|
@ehumph @avahoffman new commit uses iframe and the embed this map url from google maps. It also renders on my local copy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What changes are being implemented in this Pull Request?
Embedding a sampling map
What was your approach?
Using
knitr::include_url()to embedWhat GitHub issue does your pull request address?
Issue #7