Skip to content

Commit

Permalink
Merge branch 'main' into refactor-duplicate-code
Browse files Browse the repository at this point in the history
  • Loading branch information
Dagonite committed Sep 19, 2024
2 parents b925f02 + 437a26f commit 8dd7f79
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 53 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/scorecard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
publish_results: true

- name: "Upload artifact"
uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
with:
name: SARIF file
path: results.sarif
Expand Down
17 changes: 3 additions & 14 deletions src/Jobs/JobsBase.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,8 @@ interface JobsBaseProps {
customHeaders?: React.ReactNode;
customRowCells?: (Job: Job) => React.ReactNode;
children?: React.ReactNode;
fetchJobs: () => Promise<void>; // Fetch jobs prop
fetchTotalCount: () => Promise<void>; // Fetch total count prop
fetchJobs: () => Promise<void>;
fetchTotalCount: () => Promise<void>;
maxHeight?: number;
}

Expand Down Expand Up @@ -242,16 +242,6 @@ const JobsBase: React.FC<JobsBaseProps> = ({
return fileNameWithExtension.split('.')[0];
};

const getFileType = (fileName: string): JSX.Element => {
if (fileName.endsWith('.nxspe') || fileName.endsWith('.nxs') || fileName.endsWith('.h5')) {
return <JoinFull fontSize="small" style={{ marginRight: '8px' }} />;
} else if (fileName.endsWith('.txt')) {
return <InsertDriveFile fontSize="small" style={{ marginRight: '8px' }} />;
} else {
return <Folder fontSize="small" style={{ marginRight: '8px' }} />;
}
};

const parseJobOutputs = (): JSX.Element | JSX.Element[] | undefined => {
try {
let outputs;
Expand All @@ -269,14 +259,13 @@ const JobsBase: React.FC<JobsBaseProps> = ({
<Box maxHeight="80px" display="flex" alignItems="center" justifyContent="space-between" width="100%">
<Box display="flex" alignItems="center">
<Box display="flex" alignItems="center" sx={{ overflow: 'hidden' }}>
{getFileType(output)}
<Typography
variant="body2"
sx={{
overflow: 'hidden',
textOverflow: 'ellipsis',
whiteSpace: 'nowrap',
maxWidth: '200px',
maxWidth: '260px',
}}
title={output}
>
Expand Down
65 changes: 27 additions & 38 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3341,17 +3341,7 @@ __metadata:
languageName: node
linkType: hard

"@types/eslint-scope@npm:^3.7.3":
version: 3.7.7
resolution: "@types/eslint-scope@npm:3.7.7"
dependencies:
"@types/eslint": "*"
"@types/estree": "*"
checksum: e2889a124aaab0b89af1bab5959847c5bec09809209255de0e63b9f54c629a94781daa04adb66bffcdd742f5e25a17614fb933965093c0eea64aacda4309380e
languageName: node
linkType: hard

"@types/eslint@npm:*, @types/eslint@npm:^7.29.0 || ^8.4.1":
"@types/eslint@npm:^7.29.0 || ^8.4.1":
version: 8.56.9
resolution: "@types/eslint@npm:8.56.9"
dependencies:
Expand Down Expand Up @@ -4213,12 +4203,12 @@ __metadata:
languageName: node
linkType: hard

"acorn-import-assertions@npm:^1.9.0":
version: 1.9.0
resolution: "acorn-import-assertions@npm:1.9.0"
"acorn-import-attributes@npm:^1.9.5":
version: 1.9.5
resolution: "acorn-import-attributes@npm:1.9.5"
peerDependencies:
acorn: ^8
checksum: 944fb2659d0845c467066bdcda2e20c05abe3aaf11972116df457ce2627628a81764d800dd55031ba19de513ee0d43bb771bc679cc0eda66dc8b4fade143bc0c
checksum: 1c0c49b6a244503964ae46ae850baccf306e84caf99bc2010ed6103c69a423987b07b520a6c619f075d215388bd4923eccac995886a54309eda049ab78a4be95
languageName: node
linkType: hard

Expand Down Expand Up @@ -5131,12 +5121,12 @@ __metadata:
languageName: node
linkType: hard

"braces@npm:^3.0.2, braces@npm:~3.0.2":
version: 3.0.2
resolution: "braces@npm:3.0.2"
"braces@npm:^3.0.3, braces@npm:~3.0.2":
version: 3.0.3
resolution: "braces@npm:3.0.3"
dependencies:
fill-range: ^7.0.1
checksum: e2a8e769a863f3d4ee887b5fe21f63193a891c68b612ddb4b68d82d1b5f3ff9073af066c343e9867a393fe4c2555dcb33e89b937195feb9c1613d259edfcd459
fill-range: ^7.1.1
checksum: b95aa0b3bd909f6cd1720ffcf031aeaf46154dd88b4da01f9a1d3f7ea866a79eba76a6d01cbc3c422b2ee5cdc39a4f02491058d5df0d7bf6e6a162a832df1f69
languageName: node
linkType: hard

Expand Down Expand Up @@ -6812,13 +6802,13 @@ __metadata:
languageName: node
linkType: hard

"enhanced-resolve@npm:^5.16.0":
version: 5.16.0
resolution: "enhanced-resolve@npm:5.16.0"
"enhanced-resolve@npm:^5.17.1":
version: 5.17.1
resolution: "enhanced-resolve@npm:5.17.1"
dependencies:
graceful-fs: ^4.2.4
tapable: ^2.2.0
checksum: ccfd01850ecf2aa51e8554d539973319ff7d8a539ef1e0ba3460a0ccad6223c4ef6e19165ee64161b459cd8a48df10f52af4434c60023c65fde6afa32d475f7e
checksum: 4bc38cf1cea96456f97503db7280394177d1bc46f8f87c267297d04f795ac5efa81e48115a2f5b6273c781027b5b6bfc5f62b54df629e4d25fa7001a86624f59
languageName: node
linkType: hard

Expand Down Expand Up @@ -8002,12 +7992,12 @@ __metadata:
languageName: node
linkType: hard

"fill-range@npm:^7.0.1":
version: 7.0.1
resolution: "fill-range@npm:7.0.1"
"fill-range@npm:^7.1.1":
version: 7.1.1
resolution: "fill-range@npm:7.1.1"
dependencies:
to-regex-range: ^5.0.1
checksum: cc283f4e65b504259e64fd969bcf4def4eb08d85565e906b7d36516e87819db52029a76b6363d0f02d0d532f0033c9603b9e2d943d56ee3b0d4f7ad3328ff917
checksum: b4abfbca3839a3d55e4ae5ec62e131e2e356bf4859ce8480c64c4876100f4df292a63e5bb1618e1d7460282ca2b305653064f01654474aa35c68000980f17798
languageName: node
linkType: hard

Expand Down Expand Up @@ -11176,12 +11166,12 @@ __metadata:
linkType: hard

"micromatch@npm:^4.0.2, micromatch@npm:^4.0.4, micromatch@npm:^4.0.5":
version: 4.0.5
resolution: "micromatch@npm:4.0.5"
version: 4.0.8
resolution: "micromatch@npm:4.0.8"
dependencies:
braces: ^3.0.2
braces: ^3.0.3
picomatch: ^2.3.1
checksum: 02a17b671c06e8fefeeb6ef996119c1e597c942e632a21ef589154f23898c9c6a9858526246abb14f8bca6e77734aa9dcf65476fca47cedfb80d9577d52843fc
checksum: 79920eb634e6f400b464a954fcfa589c4e7c7143209488e44baf627f9affc8b1e306f41f4f0deedde97e69cb725920879462d3e750ab3bd3c1aed675bb3a8966
languageName: node
linkType: hard

Expand Down Expand Up @@ -16082,19 +16072,18 @@ __metadata:
linkType: hard

"webpack@npm:^5.64.4":
version: 5.91.0
resolution: "webpack@npm:5.91.0"
version: 5.94.0
resolution: "webpack@npm:5.94.0"
dependencies:
"@types/eslint-scope": ^3.7.3
"@types/estree": ^1.0.5
"@webassemblyjs/ast": ^1.12.1
"@webassemblyjs/wasm-edit": ^1.12.1
"@webassemblyjs/wasm-parser": ^1.12.1
acorn: ^8.7.1
acorn-import-assertions: ^1.9.0
acorn-import-attributes: ^1.9.5
browserslist: ^4.21.10
chrome-trace-event: ^1.0.2
enhanced-resolve: ^5.16.0
enhanced-resolve: ^5.17.1
es-module-lexer: ^1.2.1
eslint-scope: 5.1.1
events: ^3.2.0
Expand All @@ -16114,7 +16103,7 @@ __metadata:
optional: true
bin:
webpack: bin/webpack.js
checksum: f1073715dbb1ed5c070affef293d800a867708bcbc5aba4d8baee87660e0cf53c55966a6f36fab078d1d6c9567cdcd0a9086bdfb607cab87ea68c6449791b9a3
checksum: 6a3d667be304a69cd6dcb8d676bc29f47642c0d389af514cfcd646eaaa809961bc6989fc4b2621a717dfc461130f29c6e20006d62a32e012dafaa9517813a4e6
languageName: node
linkType: hard

Expand Down

0 comments on commit 8dd7f79

Please sign in to comment.