Replace actions-rs/clippy-check with giraffate/clippy-action #725
hatchanAnnotations
1 error and 3 warnings
|
build
reviewdog exited with status code: 1
|
|
[clippy] src/notebooks.rs#L194:
src/notebooks.rs#L194
warning: use of `unwrap_or_else` to construct default value
--> src/notebooks.rs:194:45
|
194 | .front_matter(args.front_matter.unwrap_or_else(FrontMatter::new))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `#[warn(clippy::unwrap_or_default)]` on by default
|
|
[clippy] src/templates.rs#L543:
src/templates.rs#L543
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/templates.rs:543:36
|
543 | let notebook = notebook_create(&client, workspace_id, notebook)
| ^^^^^^^ help: change this to: `client`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
[clippy] src/update.rs#L130:
src/update.rs#L130
warning: redundant guard
--> src/update.rs:130:42
|
130 | Some((sha256_hash, file)) if file == "fp" => Some(sha256_hash.to_owned()),
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_guards
= note: `#[warn(clippy::redundant_guards)]` on by default
help: try
|
130 - Some((sha256_hash, file)) if file == "fp" => Some(sha256_hash.to_owned()),
130 + Some((sha256_hash, "fp")) => Some(sha256_hash.to_owned()),
|
|