Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the config has a default listen port #317

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Ensure that the config has a default listen port #317

merged 2 commits into from
Oct 14, 2024

Conversation

stephlow
Copy link
Member

Fixes FP-4199

@stephlow stephlow requested a review from a team as a code owner October 10, 2024 14:38
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 10, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/fiberplane/fpx/@fiberplane/studio@317

pnpm add https://pkg.pr.new/fiberplane/fpx/@fiberplane/hono-otel@317

commit: 821088f

hatchan
hatchan reviewed Oct 10, 2024
View reviewed changes
fpx-app/src/api_manager/legacy.rs Outdated Show resolved Hide resolved
fpx/src/config.rs Show resolved Hide resolved
@stephlow stephlow requested a review from hatchan October 11, 2024 16:02
@stephlow stephlow merged commit 381bc65 into tauri-main Oct 14, 2024
6 checks passed
@stephlow stephlow deleted the fp-4199-ensure-that-the-parse-config-struct-always-has-a-listen_port branch October 14, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hatchan hatchan hatchan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephlow @hatchan