Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mistral, use "ai" lib #321

Merged
merged 29 commits into from
Oct 18, 2024
Merged

Add Mistral, use "ai" lib #321

merged 29 commits into from
Oct 18, 2024

Conversation

keturiosakys
Copy link
Member

This PR consolidates interfaces with AI providers using the ai library from Vercel and adds support for Mistral.

@keturiosakys keturiosakys marked this pull request as ready for review October 15, 2024 21:02
@keturiosakys keturiosakys changed the title WIP: Add Mistral, use "ai" lib Add Mistral, use "ai" lib Oct 15, 2024
Copy link

pkg-pr-new bot commented Oct 15, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/fiberplane/fpx/@fiberplane/studio@321
pnpm add https://pkg.pr.new/fiberplane/fpx/@fiberplane/hono-otel@321

commit: 9ed7d96

parsedContent.openaiApiKey = undefined;
parsedContent.anthropicApiKey = undefined;
}
// if (!parsedContent.aiEnabled) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd say either remove this chunk or uncomment

part of the logic behind this was to allow the end user to delete api keys... but i don't think that worked anyhow

Copy link
Contributor

@brettimus brettimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved just needs to fix the things i identified when testing

we will probably wanna check out ade's pr after this too, to look for possible regressions ¯_(ツ)_/¯

@brettimus
Copy link
Contributor

two things:

  1. Don't forget to cut a new release of the types package
  2. Changelog!

@keturiosakys keturiosakys merged commit fe38e62 into main Oct 18, 2024
4 checks passed
@keturiosakys keturiosakys deleted the ai-providers branch October 18, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants