Embed Studio artifacts into fpx cli #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatchan
commented
Jun 21, 2024
| ) -> axum::Router { | ||
| let api_router = api_router(base_url, events, store, inspector_service); | ||
| axum::Router::new() | ||
| .nest("/api/", api_router) |
There was a problem hiding this comment.
This is now split into its own router, since that way we can have separate fallback handlers. The only downside is that the routes in the inner router do not have the /api/ prefix.
hatchan
commented
Jun 21, 2024
| @@ -42,7 +43,19 @@ impl FromRef<ApiState> for InspectorService { | |||
| } | |||
|
|
|||
| /// Create a API and expose it through a axum router. | |||
| pub async fn create_api( | |||
There was a problem hiding this comment.
Not sure why this was async, so removed it
hatchan
commented
Jun 21, 2024
fpx/src/data.rs
Outdated
| @@ -126,6 +126,7 @@ pub enum DbError { | |||
| InternalError(#[from] libsql::Error), | |||
| } | |||
|
|
|||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
Just to suppress any compile warnings / clippies
stephlow
approved these changes
Jun 21, 2024
mellowagain
approved these changes
Jun 21, 2024
When retrieving a file from a dir_entry, use the _full_ path, not just the name within the dir_entry. Not sure if this is a bug or not
Enabling this requires that Studio is compiled. Otherwise compilation will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently requires a feature flag to actually embed the Studio. If this is enabled, then it requires that the studio is build. To make it easier to work with fpx, I have made this an optin, for mostly the CI build.
Resolves: FP-3793