Requestor API routes #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hatchan
reviewed
Jul 25, 2024
hatchan
approved these changes
Jul 30, 2024
| @@ -113,6 +140,6 @@ impl ApiClient { | |||
| ) -> Result<Vec<models::Span>, ApiClientError<SpanGetError>> { | |||
| let path = format!("api/traces/{}/spans", trace_id.as_ref()); | |||
|
|
|||
| self.do_req(Method::GET, path).await | |||
| self.do_req(Method::GET, path, None::<()>).await | |||
There was a problem hiding this comment.
Not a big fan of having to define these ::<()> things, but this is fine for now. We can solve this another time.
There was a problem hiding this comment.
Wasn't a fan either, but couldn't figure out a way to make it compile without these type annotations :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same changes as #86, but somehow the git history got borked there so I just copied over the changes to a new branch to get it out of the way