-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bootstrap.sh URLs, docker image bases, and add RPi Docker file #8
Conversation
Changes base docker images to openjdk instead of dockerfile/java, where available
Nice! Thank you very much, @chigozienri! |
@ctrueden Do you know how to get this to propagate through to docker hub? |
@chigozienri I'm sorry, I don't. @hinerm Are you watching GitHub these days? Any quick guidance? |
@ctrueden : if I recall correctly from Dresden 2017, I don't remember our tracking down info about either of the orgs: Which also reminds me of whether or not it's worth dredging imagej/ImageJ#182 back up. @chigozienri happy to hear your thoughts there, if you have any. |
@joshmoore Maybe it would make sense to create a repository at imagej/dockerfiles? I just don't have time right now to work on the Docker side of things, sorry. But if you—or anyone in the community who is interested—wants to step up as maintainer of Docker configuration for ImageJ and/or Fiji, that would be wonderful. I reached out to @hinerm just now asking him to add me as admin to those orgs, so that we can move forward. |
@ctrueden : imagej/dockerfiles probably only makes since if fiji/dockerfiles is being deprecated. The imagej/imagej dockerfile is for devs and won't be as useful if it's elsewhere. (But also ok if it's nowhere.) And in general, happy to get my hands dirty to keep these working. |
@joshmoore Thanks to Mark, I am now an owner of the imagej and fiji orgs on Docker Hub. I added you as an owner as well. I agree that getting imagej/ImageJ#182 fully operational would be great. But partly that depends on getting the ImageJ Launcher fixes fully released and integrated into the ImageJ POM, no? As well as completing scijava/scijava-maven-plugin#17, right? Edit: Hmm, it seems the |
@chigozienri : based on the above, I'm in the process of testing out your changes here (and hopefully getting them into travis). Note, however, that your arm Dockerfile is currently failing with:
@ctrueden : once I finish testing this PR and getting it on Docker Hub, I'll have to go back to the state of 182. IIRC most things worked and I was mostly using it to evaluate work someone (likely you) were doing around Java 8. i.e. I don't know if there is an immediate blocker.
Understood, and happy to be told "This" is the way to do it, but for the moment, I think there's room for having separate strategies in the imagej/imagej dev docker versus the fiji/dockerfiles ones. i.e. I don't intend to transfer any style changes to fiji/dockerfiles until there's a clear need/desire. The biggest issue I see so far in trying to build them all is that JDK6 might fall by the wayside at least initially. @dscho : 👋 🕺 🍺 Hope all is well. |
@joshmoore I just ran it fresh on a raspberry pi as follows
and got no error. The "exec format error" was exactly the error that I was trying to solve: I was getting it on the raspberry pi when I tried to use the fiji-openjdk-8 Dockerfile. Note that the arm Dockerfile I wrote uses |
Gotcha. Hmmm.... so that'll either leave it irregularly tested or perhaps something like:
can be put in place... |
No description provided.