-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add empty state to chart widget #13408
base: 3.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, @juliangums!
I don't like the duplication of empty state Blade views.
Since I was already planning to extract the empty state component from tables, shall we get #13252 done before merging your new feature?
@zepfietje that would make a ton of sense. Let me know when that’s done or if you need any help just instruct me. |
Great! It's at the top of my list, so will get to it as soon as possible. I'll mark this PR as draft until we can move forward. 👍 |
Started working on #13642. |
Description
Caution
DON'T MERGE THIS YET!
@danharrin as discussed in #13311 I have added a feature to display an empty state on chart widgets. Before this is merged, I'd like to ask a couple of things as I am not entirely familiar with everything in Filament:
en
andde
. Is that enough? How are all the other translations handled for so many languages?Let me know and I'll get the rest sorted.
Otherwise, it's ready to be tested.
Visual changes
Functional changes
composer cs
command.