Base64 attachments #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Message.parse() takes `signal: SignalAPI` instance as parameter, which allows us to call its new get_attachment() method. As a result, the Message.parse() needs to be `async` now.
Era-Dorta
commented
Oct 12, 2024
| self.assertEqual(message.reaction, "👍") | ||
|
|
||
| @patch("aiohttp.ClientSession.get", new_callable=AsyncMock) | ||
| async def test_attachments(self, mock_get): |
There was a problem hiding this comment.
This test is not enough, it only tests receiving attachments. Should check sending an attachment. Probably also add a new message with an attachment here too https://github.com/filipre/signalbot/blob/master/tests/test_api.py#L36C15-L36C27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #12 on top of the current master.