Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall demo hidden release INTER-378 #111

Merged
merged 49 commits into from
Jan 12, 2024
Merged

Firewall demo hidden release INTER-378 #111

merged 49 commits into from
Jan 12, 2024

Conversation

JuroUhlar
Copy link
Collaborator

@JuroUhlar JuroUhlar commented Dec 20, 2023

This is a prelimanary "hidden/test release" PR:

  • The style/design is still a prototype but the functionality itself, backend code and tests should be polished and up to standard.
  • The demo is available on https://staging.fingerprinthub.com/bot-firewall but hidden from navigation.
  • The intention is to merge this into production to test it on the production domain, subscription, Cloudfront and Cloudflare distributions. Then once the final design is ready and everything is tested, I will create a follow up PR to make the final pretty version visible to users.

Some notes about the changes:

  • Running the production server on Digital Ocean will now require running a node-cron process in parallel.
  • The e2e test for this use case uses staging.fingerprinthub.com and runs in Chrome only (running multiple instances of of it in parallel leads to failures as they access the same Cloudflare site settings).

All feedback welcome! I tried to explain my choices in the comments but I might have missed a better way to do something. Thanks!

@JuroUhlar JuroUhlar changed the title WIP: Feat/firewall demo Firewall demo hidden release Jan 4, 2024
@JuroUhlar JuroUhlar marked this pull request as ready for review January 4, 2024 08:23
.github/workflows/ci.yml Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
src/pages/api/bot-firewall/block-ip.ts Outdated Show resolved Hide resolved
src/pages/bot-firewall/index.tsx Outdated Show resolved Hide resolved
src/server/botd-firewall/cloudflareApiHelper.ts Outdated Show resolved Hide resolved
src/pages/api/bot-firewall/block-ip.ts Outdated Show resolved Hide resolved
src/pages/bot-firewall/index.tsx Outdated Show resolved Hide resolved
@JuroUhlar JuroUhlar removed the request for review from TheUnderScorer January 12, 2024 14:36
@ilfa ilfa merged commit ca434eb into main Jan 12, 2024
5 checks passed
@ilfa ilfa deleted the feat/firewall-demo branch January 12, 2024 14:42
@JuroUhlar JuroUhlar changed the title Firewall demo hidden release Firewall demo hidden release INTER-378 Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants