Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icon color for favorite icon button #1367

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

Breiby
Copy link
Member

@Breiby Breiby commented Aug 6, 2024

Why?

Icon color that was set when changing to Warp colors was not correct.

What?

Update to iconSubtle for untoggled state.

Version Change

Breaking because of changes to Style struct.

UI Changes

Before After
Screenshot 2024-08-06 at 17 23 39 Screenshot 2024-08-06 at 17 22 05
Screenshot 2024-08-06 at 17 23 25 Screenshot 2024-08-06 at 17 23 00

@Breiby Breiby requested a review from a team August 6, 2024 15:25
@Breiby Breiby self-assigned this Aug 6, 2024
@Breiby Breiby requested review from msaadq, thorbjxrn and sakhnenkoff and removed request for a team August 6, 2024 15:25
Copy link
Contributor

@AndreyMomot AndreyMomot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Breiby Breiby force-pushed the bb/Swiftui-icon-button-color branch from 9820c86 to 7c0da40 Compare August 7, 2024 08:22
@Breiby Breiby force-pushed the bb/Swiftui-icon-button-color branch from 7c0da40 to 32a84c3 Compare August 9, 2024 08:41
@Breiby Breiby merged commit 88372b8 into master Aug 9, 2024
1 check passed
@Breiby Breiby deleted the bb/Swiftui-icon-button-color branch August 9, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants