Skip to content

Commit

Permalink
Fix FirebaseCore tests comments (#13777)
Browse files Browse the repository at this point in the history
  • Loading branch information
MojtabaHs authored Oct 3, 2024
1 parent 0a36c2a commit 2a56375
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions FirebaseCore/Tests/Unit/FIRAppTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ + (void)tearDown {
// We stop mocking `FIRHeartbeatLogger` in the class `tearDown` method to
// prevent interfering with other tests that use the real `FIRHeartbeatLogger`.
// Doing this in the instance `tearDown` causes test failures due to a race
// condition between `NSNoticationCenter` and `OCMVerifyAllWithDelay`.
// condition between `NSNotificationCenter` and `OCMVerifyAllWithDelay`.
// Affected tests:
// - testHeartbeatLogIsAttemptedWhenAppDidBecomeActive
[OCMClassMock([FIRHeartbeatLogger class]) stopMocking];
Expand Down Expand Up @@ -301,7 +301,7 @@ - (void)testConfigureDefaultAppInExtension {
XCTAssertThrows([FIRApp configureWithOptions:differentOptions]);
XCTAssertEqual([FIRApp allApps].count, 1);

// Explicily stop the environmentMock.
// Explicitly stop the environmentMock.
[environmentMock stopMocking];
environmentMock = nil;
}
Expand Down Expand Up @@ -330,7 +330,7 @@ - (void)testConfigureCustomAppInExtension {
XCTAssertThrows([FIRApp configureWithName:kFIRTestAppName1 options:differentOptions]);
XCTAssertEqual([FIRApp allApps].count, 1);

// Explicily stop the environmentMock.
// Explicitly stop the environmentMock.
[environmentMock stopMocking];
environmentMock = nil;
}
Expand Down Expand Up @@ -601,7 +601,7 @@ - (void)testAppIDContainsInvalidBundleIDHash {
// Uncomment if you need to measure performance of [FIRApp validateAppID:].
// It is commented because measures are heavily dependent on a build agent configuration,
// so it cannot produce reliable resault on CI
//- (void)testAppIDValidationPerfomance {
//- (void)testAppIDValidationPerformance {
// [self measureBlock:^{
// for (NSInteger i = 0; i < 100; ++i) {
// [self testAppIDPrefix];
Expand Down

0 comments on commit 2a56375

Please sign in to comment.