Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup some Firebase references in App Check Core #11578

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Cleanup some Firebase references in App Check Core #11578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions AppCheck/Sources/AppAttestProvider/GACAppAttestProvider.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,6 @@

NS_ASSUME_NONNULL_BEGIN

// TODO(andrewheard): Remove from generic App Check SDK.
// FIREBASE_APP_CHECK_ONLY_BEGIN
static NSString *const kHeartbeatKey = @"X-firebase-client";
// FIREBASE_APP_CHECK_ONLY_END

/// A data object that contains all key attest data required for FAC token exchange.
@interface GACAppAttestKeyAttestationResult : NSObject

Expand Down Expand Up @@ -134,7 +129,7 @@ - (instancetype)initWithAppAttestService:(id<GACAppAttestService>)appAttestServi
_keyIDStorage = keyIDStorage;
_artifactStorage = artifactStorage;
_backoffWrapper = backoffWrapper;
_queue = dispatch_queue_create("com.firebase.GACAppAttestProvider", DISPATCH_QUEUE_SERIAL);
_queue = dispatch_queue_create("com.google.GACAppAttestProvider", DISPATCH_QUEUE_SERIAL);
}
return self;
}
Expand Down
2 changes: 1 addition & 1 deletion AppCheck/Sources/Core/Errors/GACAppCheckErrors.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@

#import "AppCheck/Sources/Public/AppCheck/GACAppCheckErrors.h"

NSErrorDomain const GACAppCheckErrorDomain = @"com.firebase.appCheck";
NSErrorDomain const GACAppCheckErrorDomain = @"com.google.app_check_core";
8 changes: 0 additions & 8 deletions AppCheck/Sources/Core/GACAppCheck.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,6 @@

NS_ASSUME_NONNULL_BEGIN

// TODO(andrewheard): Remove from generic App Check SDK.
// FIREBASE_APP_CHECK_ONLY_BEGIN
static NSString *const kGACAppCheckTokenAutoRefreshEnabledUserDefaultsPrefix =
@"GACAppCheckTokenAutoRefreshEnabled_";
static NSString *const kGACAppCheckTokenAutoRefreshEnabledInfoPlistKey =
@"FirebaseAppCheckTokenAutoRefreshEnabled";
// FIREBASE_APP_CHECK_ONLY_END

static const NSTimeInterval kTokenExpirationThreshold = 5 * 60; // 5 min.

static NSString *const kDummyFACTokenValue = @"eyJlcnJvciI6IlVOS05PV05fRVJST1IifQ==";
Expand Down
2 changes: 1 addition & 1 deletion AppCheck/Sources/Core/Storage/GACAppCheckStorage.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

NS_ASSUME_NONNULL_BEGIN

static NSString *const kKeychainService = @"com.firebase.app_check.token_storage";
static NSString *const kKeychainService = @"com.google.app_check_core.token_storage";

@interface GACAppCheckStorage ()

Expand Down
Loading