Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): Add 'Custom Auth Domain' support #11594

Closed
wants to merge 0 commits into from
Closed

Conversation

pragatimodi
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2023

Apple API Diff Report

Commit: a7b7cb8
Last updated: Wed Jul 26 11:53 PDT 2023
View workflow logs & download artifacts


FirebaseAuth

Classes

FIRAuth
[ADDED] -getAuthDomain
Swift:
+  func getDomain () -> String ?
Objective-C:
+  - ( nullable NSString * ) getAuthDomain ;
[ADDED] AuthDomain
Swift:
+  var authDomain : String ? { get set }
Objective-C:
+  @property ( nonatomic , strong , nullable ) NSString * AuthDomain ;

@google-oss-bot
Copy link

google-oss-bot commented Jul 24, 2023

Size Report 1

Affected Products

  • FirebaseAuth

    TypeBase (4084532)Merge (27d9090)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LssukUxlJC.html

@google-oss-bot
Copy link

google-oss-bot commented Jul 24, 2023

Coverage Report 1

Affected Products

  • FirebaseAuth-iOS-FirebaseAuth.framework

    Overall coverage changed from 68.89% (24c9cba) to 68.94% (a7b7cb8) by +0.05%.

    FilenameBase (24c9cba)Merge (a7b7cb8)Diff
    FIRAuth.m80.49%80.30%-0.20%
    FIRAuthWebUtils.m95.51%92.86%-2.65%
    FIROAuthProvider.m85.93%85.67%-0.27%
  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.10% (24c9cba) to 88.04% (a7b7cb8) by -0.06%.

    FilenameBase (24c9cba)Merge (a7b7cb8)Diff
    exception.cc84.21%23.68%-60.53%
    leveldb_key.cc98.14%98.82%+0.69%
    task.cc93.91%94.78%+0.87%
  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    Overall coverage changed from 60.53% (24c9cba) to 60.56% (a7b7cb8) by +0.03%.

    FilenameBase (24c9cba)Merge (a7b7cb8)Diff
    FIRMessagingPendingTopicsList.m89.02%89.80%+0.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8LKWaw2Fkc.html

@pragatimodi pragatimodi changed the title adding public headers and implementation for FIRAuth on custom auth domains (feat): Add 'Custom Auth Domain' support Jul 26, 2023
@pragatimodi pragatimodi marked this pull request as draft July 26, 2023 18:51
@pragatimodi pragatimodi deleted the custom-auth-domain branch July 26, 2023 20:32
@firebase firebase locked and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants