Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile errors in Combine #11610

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Fix compile errors in Combine #11610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8786303
Fix compile errors in Combine
peterfriese Jul 26, 2023
0d3aa51
Fix style
peterfriese Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion FirebaseCombineSwift/Tests/Unit/Auth/AuthMocks.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,12 +104,17 @@ extension AuthBackendImplementationMock {
fatalError("You need to implement \(#function) in your mock.")
}

func getRecaptchaConfig(_ request: FIRGetRecaptchaConfigRequest,
callback: @escaping FIRGetRecaptchaConfigResponseCallback) {
fatalError("You need to implement \(#function) in your mock.")
}

func resetPassword(_ request: FIRResetPasswordRequest,
callback: @escaping FIRResetPasswordCallback) {
fatalError("You need to implement \(#function) in your mock.")
}

func post(with request: FIRAuthRPCRequest, response: FIRAuthRPCResponse,
func call(with request: FIRAuthRPCRequest, response: FIRAuthRPCResponse,
callback: @escaping (Error?) -> Void) {
fatalError("You need to implement \(#function) in your mock.")
}
Expand Down
2 changes: 1 addition & 1 deletion FirebaseCombineSwift/Tests/Unit/Auth/SignInWithGameCenterTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class SignInWithGameCenterTests: XCTestCase {
var contentType: String?
var handler: FIRAuthBackendRPCIssuerCompletionHandler?

func asyncPostToURL(with requestConfiguration: FIRAuthRequestConfiguration, url URL: URL,
func asyncCallToURL(with requestConfiguration: FIRAuthRequestConfiguration, url URL: URL,
body: Data?, contentType: String,
completionHandler handler: @escaping FIRAuthBackendRPCIssuerCompletionHandler) {
requestURL = URL
Expand Down
2 changes: 2 additions & 0 deletions FirebaseCombineSwift/Tests/Unit/FirebaseCombine-unit-Bridging-Header.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@
#import "FirebaseAuth/Sources/Backend/RPC/FIRGetOOBConfirmationCodeResponse.h"
#import "FirebaseAuth/Sources/Backend/RPC/FIRGetProjectConfigRequest.h"
#import "FirebaseAuth/Sources/Backend/RPC/FIRGetProjectConfigResponse.h"
#import "FirebaseAuth/Sources/Backend/RPC/FIRGetRecaptchaConfigRequest.h"
#import "FirebaseAuth/Sources/Backend/RPC/FIRGetRecaptchaConfigResponse.h"
#import "FirebaseAuth/Sources/Backend/RPC/FIRResetPasswordRequest.h"
#import "FirebaseAuth/Sources/Backend/RPC/FIRResetPasswordResponse.h"
#import "FirebaseAuth/Sources/Backend/RPC/FIRRevokeTokenRequest.h"
Expand Down
Loading