Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auth-swift] Fix Extensions build, AuthNotificationManager fixes #11629

Merged
merged 4 commits into from
Aug 3, 2023
Merged

[auth-swift] Fix Extensions build, AuthNotificationManager fixes #11629

merged 4 commits into from
Aug 3, 2023

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Jul 28, 2023 •
edited
Loading

  • Address compile time failures for app extensions in Auth.swift (thanks to @ryanwilson for the incantation)
  • Similar extension build fix for AuthDefaultUIDelegate.swift
  • Fix and simplify implementation and unit tests for AuthNotificationManager
  • Fix a unit test flake
  • Disable unit tests for SPM that rely on UIApplication.shared being non-zero

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

paulb777
paulb777 commented Jul 28, 2023
View reviewed changes
Copy link
Member Author

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

FirebaseAuth/Tests/Unit/AuthNotificationManagerTests.swift Show resolved Hide resolved
FirebaseAuth/Tests/Unit/AuthTests.swift Show resolved Hide resolved
FirebaseAuth/Sources/Swift/Auth/Auth.swift Show resolved Hide resolved
@paulb777
Copy link
Member Author

SPM tests are failing because they were previously relying on a nil UIApplication that wasn't detected by the type system

@paulb777
Copy link
Member Author

Note the 00000000 on the not nullable UIApplication when running the tests from before this PR

Screenshot 2023-07-28 at 3 58 07 PM

@paulb777 paulb777 changed the title [auth-swift] Auth.swift for Extensions, AuthNotificationManager fixes [auth-swift] Fix Extensions build, AuthNotificationManager fixes Jul 29, 2023
@paulb777 paulb777 merged commit cca398e into auth-swift Aug 3, 2023
@paulb777 paulb777 deleted the pb-extensions1 branch August 3, 2023 20:01
@firebase firebase locked and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @google-oss-bot @ryanwilson