[App Check] Add strict nil token / error handling in App Attest service #11645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncooke3
reviewed
Aug 3, 2023
| [self randomChallengeFromResponseBody:response.HTTPBody | ||
| error:&error]; | ||
|
|
||
| return randomChallenge ?: error; |
There was a problem hiding this comment.
Good find. This syntax probably opens the door for nil, nil scenarios.
|
Please close, merge, or comment. We plan to close stale PRs on November 28, 2023. |
|
Closing. If we decide to implement this in the future it'll need to be in https://github.com/google/app-check. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks / handling to ensure that callbacks in App Check's App Attest service are always called with a token or an error (they must not both be
nil).#no-changelog