Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Config] Update RemoteConfig and RemoteConfigSwift CHANGELOGs #11749

Merged
merged 2 commits into from
Sep 3, 2023
Merged

[Config] Update RemoteConfig and RemoteConfigSwift CHANGELOGs #11749

merged 2 commits into from
Sep 3, 2023

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Aug 29, 2023

No description provided.

@ncooke3 ncooke3 added this to the 10.15.0 - M137 milestone Aug 29, 2023
@ncooke3 ncooke3 removed this from the 10.15.0 - M137 milestone Sep 1, 2023
@ncooke3 ncooke3 changed the base branch from master to rc-swift-merged September 1, 2023 22:27
@ncooke3 ncooke3 marked this pull request as ready for review September 1, 2023 22:27
@ncooke3
Copy link
Member Author

ncooke3 commented Sep 1, 2023

This will get re-reviewed when merging this PR's base branch into master. Probably won't make it for M137, but likely M138.

morganchen12
morganchen12 approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think you can put DO_NOT_SUBMIT in the PR description if you want to avoid accidentally submitting it for the code freeze

@ncooke3
Copy link
Member Author

ncooke3 commented Sep 3, 2023

Merging into feature branch: rc-swift-merged

@ncooke3 ncooke3 merged commit 444c7e9 into rc-swift-merged Sep 3, 2023
57 checks passed
@ncooke3 ncooke3 deleted the nc/rc-pod-merge-non-breaking-5 branch September 3, 2023 02:21
@firebase firebase locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

Assignees
No one assigned
Labels
api: remoteconfig
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncooke3 @morganchen12 @google-oss-bot