-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[InAppMessaging] Consolidate FIAM and FIAMSwift #11800
Conversation
Coverage Report 1Affected Products
Test Logs |
b5dcd63
to
b31c3fb
Compare
Size Report 1Affected ProductsTest Logs |
Closed and re-opened to deflate some transient network failures in CI. |
I'm a bit unsure of how to fix After reproducing locally, it seems that the I'm able to get things linting successfully if I lint the specs together: pod spec lint FirebaseInAppMessagingSwift.podspec FirebaseInAppMessaging.podspec --platforms=ios --skip-tests --allow-warnings --sources=https://github.com/firebase/SpecsTesting,https://cdn.cocoapods.org/ I'd imagine this should workflow failure may happen anytime multiple specs are updated in a single PR where the changes are heavily dependent. Is this considered a bug in the workflow? Should the workflow lint all changed specs together rather than breaking them up into a job matrix where each spec is linted separately? |
It's a known issue we've seen before. Historically, we've ignored interdependent spectesting issues like this until after merging and updating tags. Let's discuss next week |
9854c6a
to
7d662ff
Compare
7d662ff
to
c073093
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May also want to notify @mikehardy when the consolidation podspecs are staged.
Context
Tasks
Important