Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Database] Consolidate Database and DatabaseSwift #11807

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Sep 14, 2023

Context

  • The contents of RTDB's Swift extension SDK has been moved into the main RTDB module, and the RTDB Swift extension SDK now re-exports the API that used to live in it.
  • This change should be non-breaking.

Tasks

  • The affected extension podspecs should be versioned to pin to the releasing version.
  • When this PR is merged, stage the affected podspecs and notify the Games team.

Important

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Apple API Diff Report

Commit: a708f8e
Last updated: Thu Oct 12 10:35 PDT 2023
View workflow logs & download artifacts


FirebaseDatabaseSwift

[REMOVED] Extensions
Swift:
-    public extension DataSnapshot
-      func data < T : Decodable > ( as type : T . Type , decoder : Database . Decoder = Database . Decoder ()) throws -> T
-    public extension Database
-      typealias Encoder = FirebaseDataEncoder
-      typealias Decoder = FirebaseDataDecoder
-    public extension DatabaseReference
-      func setValue < T : Encodable > ( from value : T , encoder : Database . Encoder = Database . Encoder (), completion : (( Error ?) -> Void )? = nil ) throws
[REMOVED] Structures
Swift:
-    @propertyWrapper public struct ServerTimestamp : Codable , Equatable , Hashable
-      public init ( wrappedValue value : Date ?)
-      public var wrappedValue : Date ? { get set }
-      public init ( from decoder : Decoder ) throws
-      public func encode ( to encoder : Encoder ) throws

@google-oss-bot
Copy link

google-oss-bot commented Sep 14, 2023

Coverage Report 1

Affected Products

  • FirebaseDatabase-iOS-FirebaseDatabase.framework

    Overall coverage changed from ? (1e0f294) to 56.83% (a708f8e) by ?.

    105 individual files with coverage change

    FilenameBase (1e0f294)Merge (a708f8e)Diff
    APLevelDB.mm?61.30%?
    DatabaseReference+WriteEncodable.swift?0.00%?
    DataSnapshot+ReadDecodable.swift?0.00%?
    FAckUserWrite.m?83.33%?
    FArraySortedDictionary.m?97.49%?
    FAtomicNumber.m?100.00%?
    fbase64.c?32.00%?
    FCacheNode.m?100.00%?
    FCachePolicy.m?17.14%?
    FCancelEvent.m?0.00%?
    FChange.m?88.24%?
    FChildChangeAccumulator.m?65.22%?
    FChildEventRegistration.m?0.00%?
    FChildrenNode.m?91.16%?
    FClock.m?100.00%?
    FCompoundHash.m?97.70%?
    FCompoundWrite.m?91.12%?
    FConnection.m?26.81%?
    FDataEvent.m?29.41%?
    FEmptyNode.m?100.00%?
    FEventEmitter.m?0.00%?
    FEventGenerator.m?95.37%?
    FEventRaiser.m?33.33%?
    FImmutableSortedDictionary.m?31.03%?
    FImmutableSortedSet.m?54.22%?
    FImmutableTree.m?85.75%?
    FIndex.m?91.67%?
    FIndexedFilter.m?96.38%?
    FIndexedNode.m?97.06%?
    FIRDatabase.m?15.76%?
    FIRDatabaseComponent.m?19.23%?
    FIRDatabaseConfig.m?59.62%?
    FIRDatabaseConnectionContextProvider.m?96.67%?
    FIRDatabaseQuery.m?3.86%?
    FIRDatabaseReference.m?6.41%?
    FIRDataSnapshot.m?89.71%?
    FIRMutableData.m?75.51%?
    FIRRetryHelper.m?83.33%?
    FIRServerValue.m?0.00%?
    FIRTransactionResult.m?0.00%?
    FKeepSyncedEventRegistration.m?0.00%?
    FKeyIndex.m?60.56%?
    FLeafNode.m?86.98%?
    FLevelDBStorageEngine.m?71.37%?
    FLimitedFilter.m?97.25%?
    FListenComplete.m?0.00%?
    FLLRBEmptyNode.m?75.00%?
    FLLRBValueNode.m?85.39%?
    FMaxNode.m?60.61%?
    FMerge.m?87.18%?
    FNamedNode.m?62.32%?
    FNextPushId.m?62.50%?
    FOperationSource.m?89.29%?
    FOverwrite.m?81.48%?
    FPath.m?94.30%?
    FPathIndex.m?88.75%?
    FPendingPut.m?0.00%?
    FPersistenceManager.m?55.19%?
    FPersistentConnection.m?21.28%?
    FPriorityIndex.m?87.84%?
    FPruneForest.m?93.08%?
    FQueryParams.m?96.24%?
    FQuerySpec.m?86.36%?
    FRangedFilter.m?93.67%?
    FRangeMerge.m?94.06%?
    FRepo.m?13.49%?
    FRepoInfo.m?73.00%?
    FRepoManager.m?29.86%?
    FServerValues.m?50.85%?
    FSnapshotHolder.m?100.00%?
    FSnapshotUtilities.m?62.06%?
    FSparseSnapshotTree.m?98.13%?
    FSRWebSocket.m?38.29%?
    FStringUtilities.m?79.41%?
    FSyncPoint.m?87.80%?
    FSyncTree.m?71.33%?
    FTrackedQuery.m?75.38%?
    FTrackedQueryManager.m?90.50%?
    FTransformedEnumerator.m?100.00%?
    FTree.m?6.04%?
    FTreeNode.m?100.00%?
    FTreeSortedDictionary.m?96.17%?
    FTreeSortedDictionaryEnumerator.m?100.00%?
    FTupleNodePath.m?0.00%?
    FTupleObjectNode.m?0.00%?
    FTuplePathValue.m?100.00%?
    FTupleRemovedQueriesEvents.m?100.00%?
    FTupleSetIdPath.m?0.00%?
    FTupleStringNode.m?0.00%?
    FTupleTransaction.m?0.00%?
    FTupleUserCallback.m?0.00%?
    FUtilities.m?74.01%?
    FValidation.m?25.32%?
    FValueEventRegistration.m?0.00%?
    FValueIndex.m?48.53%?
    FView.m?80.11%?
    FViewCache.m?100.00%?
    FViewProcessor.m?91.87%?
    FViewProcessorResult.m?100.00%?
    FWebSocketConnection.m?41.49%?
    FWriteRecord.m?45.65%?
    FWriteTree.m?75.44%?
    FWriteTreeRef.m?100.00%?
    NSData+SRB64Additions.m?81.82%?
    ServerTimestamp.swift?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/I2jKjcR6JR.html

@ncooke3 ncooke3 merged commit 2ee43e0 into master Oct 13, 2023
76 checks passed
@ncooke3 ncooke3 deleted the database-swift-merged branch October 13, 2023 18:53
@firebase firebase locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants